Fix output inconsistent result (default_integrations/monitoring)#841
Merged
tobio merged 3 commits intoelastic:mainfrom Oct 14, 2024
Merged
Fix output inconsistent result (default_integrations/monitoring)#841tobio merged 3 commits intoelastic:mainfrom
tobio merged 3 commits intoelastic:mainfrom
Conversation
tobio
reviewed
Oct 13, 2024
Member
tobio
left a comment
tobio
left a comment
There was a problem hiding this comment.
Can we get a changelog entry for this one please?
Contributor
Author
|
Sure, I'll get it later tonight
…On Sun, Oct 13, 2024, 5:49 PM Toby Brain ***@***.***> wrote:
***@***.**** commented on this pull request.
Can we get a changelog entry for this one please?
—
Reply to this email directly, view it on GitHub
<#841 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFMTBBDOHEDK3O77JMQ2JLZ3LTHJAVCNFSM6AAAAABP2WPJ46VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRUHE4TSOBXG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
.com>
|
tobio
approved these changes
Oct 14, 2024
kjwardy
pushed a commit
to kjwardy/terraform-provider-elasticstack
that referenced
this pull request
Oct 21, 2024
…stic#841) * Fix output inconsistent result (default_integrations/monitoring) * Update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #840
Add default: False to default_integrations and default_monitoring.
This was not found by the tests because both fields are set in each test.